<!DOCTYPE html>
<html>
  <head>
  </head>
  <body>
    <dl style="line-height: 1.5; margin-left: 2em">
      <dt style="clear: both; float: left; font-weight: bold; width: 8em">Author</dt>
      <dd style="margin-left: 8.5em">Yoji SHIDARA &lt;dara****@shida*****&gt;</dd>
      <dt style="clear: both; float: left; font-weight: bold; width: 8em">Date</dt>
      <dd style="margin-left: 8.5em">2012-08-02 15:07:47 +0900 (Thu, 02 Aug 2012)</dd>
      <dt style="clear: both; float: left; font-weight: bold; width: 8em">New Revision</dt>
      <dd style="margin-left: 8.5em"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4">31a45e68f321382abb19a3fb2d432d3f53f144e4</a></dd>
      <dt style="clear: both; float: left; font-weight: bold; width: 8em">Log</dt>
      <dd style="margin-left: 8.5em"><pre style="border: 1px solid #aaa; font-family: Consolas, Menlo, &quot;Liberation Mono&quot;, Courier, monospace; line-height: 1.2; padding: 0.5em">Fix broken search for not-faceted queries</pre></dd>
      <dt style="clear: both; float: left; font-weight: bold; width: 8em">Modified files</dt>
      <dd style="margin-left: 8.5em">
        <ul>
          <li><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#diff-0">lib/api/2011-02-01/search.js</a></li>
        </ul>
      </dd>
    </dl>

    <div class="diff-section" style="clear: both">
      <table style="border-collapse: collapse; border: 1px solid #aaa">
        <thead>
          <tr class="diff-header" style="border: 1px solid #aaa">
            <td colspan="3">
<pre style="border: 0; font-family: Consolas, Menlo, &quot;Liberation Mono&quot;, Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal"><span class="diff-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">  Modified: lib/api/2011-02-01/search.js (+5 -5)</span>
<span class="diff-header-mark" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">===================================================================</span>
</pre>
            </td>
          </tr>
        </thead>
        <tbody>
          <tr>
            <th class="diff-line-number" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, &quot;Liberation Mono&quot;, Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal"><span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L89">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L90">90</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L91">91</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L92">92</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L93">93</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L94">94</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L95">95</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L96">96</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L131">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L132">132</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L133">133</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L134">134</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L135">135</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L136">136</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L137">137</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L138">138</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L139">139</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L164">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L165">165</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L166">166</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L167">167</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L168">168</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L169">169</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L170">170</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L171">171</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0L172">172</a></span>
</pre>
            </th>
            <th class="diff-line-number" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, &quot;Liberation Mono&quot;, Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal"><span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R89">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R90">90</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R91">91</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R92">92</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R93">93</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R94">94</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R95">95</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R96">96</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R131">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R132">132</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R133">133</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R134">134</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R135">135</a></span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R136">136</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R137">137</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R138">138</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R139">139</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R164">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R165">165</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R166">166</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R167">167</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R168">168</a></span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R169">169</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R170">170</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R171">171</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/gcs/commit/31a45e68f321382abb19a3fb2d432d3f53f144e4#L0R172">172</a></span>
</pre>
            </th>
            <td class="diff-content" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, &quot;Liberation Mono&quot;, Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal"><span class="diff-hunk-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">@@ -90,7 +90,7 @@ <span class="diff-context" style="background-color: #ffffaa; color: #000000">exports.createHandler = function(context) {</span></span>
<span class="diff-not-changed" style="display: block; white-space: pre">     var query = request.query.q || '';</span>
<span class="diff-not-changed" style="display: block; white-space: pre">     var booleanQuery = request.query.bq || '';</span>
<span class="diff-not-changed" style="display: block; white-space: pre">     var filter = null;</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">-    var facet = request.query.facet;</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+    var facetParameter = request.query.facet;</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
<span class="diff-not-changed" style="display: block; white-space: pre">     if (booleanQuery) {</span>
<span class="diff-not-changed" style="display: block; white-space: pre">       var translator = new BooleanQueryTranslator();</span>
<span class="diff-hunk-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">@@ -132,8 +132,8 @@ <span class="diff-context" style="background-color: #ffffaa; color: #000000">exports.createHandler = function(context) {</span></span>
<span class="diff-not-changed" style="display: block; white-space: pre">       options.filter = filter;</span>
<span class="diff-not-changed" style="display: block; white-space: pre">     }</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">-    if (facet) {</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">-      options.drilldown = facet;</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+    if (facetParameter) {</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+      options.drilldown = facetParameter;</span>
<span class="diff-not-changed" style="display: block; white-space: pre">       // TODO support sorting</span>
<span class="diff-not-changed" style="display: block; white-space: pre">       // TODO support facet-FIELD-top-n parameter</span>
<span class="diff-not-changed" style="display: block; white-space: pre">     }</span>
<span class="diff-hunk-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">@@ -165,8 +165,8 @@ <span class="diff-context" style="background-color: #ffffaa; color: #000000">exports.createHandler = function(context) {</span></span>
<span class="diff-not-changed" style="display: block; white-space: pre">           },</span>
<span class="diff-not-changed" style="display: block; white-space: pre">           info: info</span>
<span class="diff-not-changed" style="display: block; white-space: pre">         };</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">-        if (facets) {</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">-          var facetNames = facet.split(',');</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+        if (facetParameter) {</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+          var facetNames = facetParameter.split(',');</span>
<span class="diff-not-changed" style="display: block; white-space: pre">           var facetsObject = {};</span>
<span class="diff-not-changed" style="display: block; white-space: pre">           facets.map(function(facet, index) {</span>
<span class="diff-not-changed" style="display: block; white-space: pre">             var facetName = facetNames[index];</span>
</pre>
            </td>
          </tr>
        </tbody>
      </table>
    </div>
  </body>
</html>