<!DOCTYPE html>
<html>
<head>
</head>
<body>
<dl style="line-height: 1.5; margin-left: 2em">
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Author</dt>
<dd style="margin-left: 8.5em">Kouhei Sutou <kou****@clear*****></dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Date</dt>
<dd style="margin-left: 8.5em">2013-06-19 17:09:27 +0900 (Wed, 19 Jun 2013)</dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">New Revision</dt>
<dd style="margin-left: 8.5em"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd">38a27e704f7f674a4b64fd3e75495a0640a076fd</a></dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Message</dt>
<dd style="margin-left: 8.5em"><pre style="border: 1px solid #aaa; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; padding: 0.5em; width: auto">Extract common code that gets record value</pre></dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Modified files</dt>
<dd style="margin-left: 8.5em">
<ul>
<li><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#diff-0">lib/droonga/plugin/handler_search.rb</a></li>
</ul>
</dd>
</dl>
<div class="diff-section" style="clear: both">
<table style="border-collapse: collapse; border: 1px solid #aaa">
<thead>
<tr class="diff-header" style="border: 1px solid #aaa">
<td colspan="3">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre"> Modified: lib/droonga/plugin/handler_search.rb (+6 -2)</span>
<span class="diff-header-mark" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">===================================================================</span>
</pre>
</td>
</tr>
</thead>
<tbody>
<tr>
<th class="diff-line-number" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0L261">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0L262">262</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0L263">263</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0L264">264</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0L265">265</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0L266">266</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0L267">267</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0L268">268</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0L269">269</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0L270">270</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0L271">271</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0L272">272</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0L273">273</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0L274">274</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0L275">275</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0L276">276</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0L277">277</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0L278">278</a></span>
</pre>
</th>
<th class="diff-line-number" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0R261">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0R262">262</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0R263">263</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0R264">264</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0R265">265</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0R266">266</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0R267">267</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0R268">268</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0R269">269</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0R270">270</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0R271">271</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0R272">272</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0R273">273</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0R274">274</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0R275">275</a></span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0R276">276</a></span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0R277">277</a></span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0R278">278</a></span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0R279">279</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0R280">280</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0R281">281</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/fluent-plugin-droonga/commit/38a27e704f7f674a4b64fd3e75495a0640a076fd#L0R282">282</a></span>
</pre>
</th>
<td class="diff-content" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-hunk-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">@@ -262,17 +262,21 @@ <span class="diff-context" style="background-color: #ffffaa; color: #000000">module Droonga</span></span>
<span class="diff-not-changed" style="display: block; white-space: pre"> def complex_record(attributes, record)</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> values = {}</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> attributes.collect do |attribute|</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- values[attribute[:label]] = attribute[:static_value] || record[attribute[:source]]</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+ values[attribute[:label]] = record_value(record, attribute)</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> end</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> values</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> end</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
<span class="diff-not-changed" style="display: block; white-space: pre"> def simple_record(attributes, record)</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> attributes.collect do |attribute|</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- attribute[:static_value] || record[attribute[:source]]</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+ record_value(record, attribute)</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> end</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> end</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+ def record_value(record, attribute)</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+ attribute[:static_value] || record[attribute[:source]]</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+ end</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> STATIC_INTEGER_VALUE_PATTERN = /\A[-+]?\d+\z/.freeze</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> STATIC_FLOAT_VALUE_PATTERN = /\A[-+]?\d*\.\d+\z/.freeze</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> STATIC_STRING_VALUE_PATTERN = /\A("[^"]*"|'[^']*')\z/.freeze</span>
</pre>
</td>
</tr>
</tbody>
</table>
</div>
</body>
</html>