<!DOCTYPE html>
<html>
<head>
</head>
<body>
<dl style="line-height: 1.5; margin-left: 2em">
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Author</dt>
<dd style="margin-left: 8.5em">Kouhei Sutou <kou****@clear*****></dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Date</dt>
<dd style="margin-left: 8.5em">2013-06-21 17:20:10 +0900 (Fri, 21 Jun 2013)</dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">New Revision</dt>
<dd style="margin-left: 8.5em"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da">4d6b086d43aa5c56ab8864b510ababab4138d4da</a></dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Message</dt>
<dd style="margin-left: 8.5em"><pre style="border: 1px solid #aaa; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; padding: 0.5em; width: auto">sub_filter: use grn_expr_get_var() intead of grn->impl->curr_expr
There are no tests for this case because this case isn't used with the
current query executor. We should add a test for this case after we
get a better query executor.</pre></dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Modified files</dt>
<dd style="margin-left: 8.5em">
<ul>
<li><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#diff-0">lib/proc.c</a></li>
</ul>
</dd>
</dl>
<div class="diff-section" style="clear: both">
<table style="border-collapse: collapse; border: 1px solid #aaa">
<thead>
<tr class="diff-header" style="border: 1px solid #aaa">
<td colspan="3">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre"> Modified: lib/proc.c (+1 -10)</span>
<span class="diff-header-mark" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">===================================================================</span>
</pre>
</td>
</tr>
</thead>
<tbody>
<tr>
<th class="diff-line-number" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0L3942">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0L3943">3943</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0L3944">3944</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0L3945">3945</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0L3946">3946</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0L3947">3947</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0L3948">3948</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0L3949">3949</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0L3950">3950</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0L3955">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0L3956">3956</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0L3957">3957</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0L3958">3958</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0L3959">3959</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0L3960">3960</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0L3961">3961</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0L3962">3962</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0L3963">3963</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0L3964">3964</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0L3965">3965</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0L3966">3966</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0L3967">3967</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0L3968">3968</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0L3969">3969</a></span>
</pre>
</th>
<th class="diff-line-number" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0R3942">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0R3943">3943</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0R3944">3944</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0R3945">3945</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0R3946">3946</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0R3947">3947</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0R3948">3948</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0R3953">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0R3954">3954</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0R3955">3955</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0R3956">3956</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0R3957">3957</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0R3958">3958</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0R3959">3959</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/4d6b086d43aa5c56ab8864b510ababab4138d4da#L0R3960">3960</a></span>
</pre>
</th>
<td class="diff-content" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-hunk-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">@@ -3943,8 +3943,6 @@ <span class="diff-context" style="background-color: #ffffaa; color: #000000">static grn_obj *</span></span>
<span class="diff-not-changed" style="display: block; white-space: pre"> func_sub_filter(grn_ctx *ctx, int nargs, grn_obj **args, grn_user_data *user_data)</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> {</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> grn_obj *found;</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- grn_obj *command = ctx->impl->curr_expr;</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- grn_obj *condition_ptr = NULL;</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> grn_obj *condition = NULL;</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> grn_obj *variable;</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> grn_obj *table = NULL;</span>
<span class="diff-hunk-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">@@ -3956,14 +3954,7 @@ <span class="diff-context" style="background-color: #ffffaa; color: #000000">func_sub_filter(grn_ctx *ctx, int nargs, grn_obj **args, grn_user_data *user_dat</span></span>
<span class="diff-not-changed" style="display: block; white-space: pre"> }</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> GRN_BOOL_SET(ctx, found, GRN_FALSE);</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- condition_ptr = grn_expr_get_var(ctx, command,</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- GRN_SELECT_INTERNAL_VAR_CONDITION,</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- strlen(GRN_SELECT_INTERNAL_VAR_CONDITION));</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- if (!condition_ptr) {</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- goto exit;</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- }</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">-</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- condition = GRN_PTR_VALUE(condition_ptr);</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+ grn_proc_get_info(ctx, user_data, NULL, NULL, &condition);</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> if (!condition) {</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> goto exit;</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> }</span>
</pre>
</td>
</tr>
</tbody>
</table>
</div>
</body>
</html>