<!DOCTYPE html>
<html>
<head>
</head>
<body>
<dl style="line-height: 1.5; margin-left: 2em">
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Author</dt>
<dd style="margin-left: 8.5em">Kouhei Sutou <kou****@clear*****></dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Date</dt>
<dd style="margin-left: 8.5em">2014-04-08 17:43:40 +0900 (Tue, 08 Apr 2014)</dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">New Revision</dt>
<dd style="margin-left: 8.5em"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c">7949ddbd0126f80a38628cb874556296ab3e283c</a></dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Message</dt>
<dd style="margin-left: 8.5em"><pre style="border: 1px solid #aaa; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; padding: 0.5em; width: auto">Simplify
We can know about the formatter is what formatter in the small methods.</pre></dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Modified files</dt>
<dd style="margin-left: 8.5em">
<ul>
<li><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#diff-0">lib/droonga/searcher.rb</a></li>
</ul>
</dd>
</dl>
<div class="diff-section" style="clear: both">
<table style="border-collapse: collapse; border: 1px solid #aaa">
<thead>
<tr class="diff-header" style="border: 1px solid #aaa">
<td colspan="3">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre"> Modified: lib/droonga/searcher.rb (+6 -11)</span>
<span class="diff-header-mark" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">===================================================================</span>
</pre>
</td>
</tr>
</thead>
<tbody>
<tr>
<th class="diff-line-number" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L621">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L622">622</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L623">623</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L624">624</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L625">625</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L626">626</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L627">627</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L628">628</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L629">629</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L630">630</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L631">631</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L632">632</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L633">633</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L634">634</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L635">635</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L636">636</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L637">637</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L639">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L640">640</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L641">641</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L642">642</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L643">643</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L644">644</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L645">645</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L646">646</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L647">647</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L648">648</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L649">649</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L650">650</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L651">651</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0L652">652</a></span>
</pre>
</th>
<th class="diff-line-number" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R621">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R622">622</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R623">623</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R624">624</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R625">625</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R626">626</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R627">627</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R628">628</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R629">629</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R630">630</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R631">631</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R632">632</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R633">633</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R635">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R636">636</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R637">637</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R638">638</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R639">639</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R640">640</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R641">641</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R642">642</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R643">643</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R644">644</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R645">645</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R646">646</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/droonga/fluent-plugin-droonga/commit/7949ddbd0126f80a38628cb874556296ab3e283c#L0R647">647</a></span>
</pre>
</th>
<td class="diff-content" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-hunk-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">@@ -622,16 +622,12 @@ <span class="diff-context" style="background-color: #ffffaa; color: #000000">module Droonga</span></span>
<span class="diff-not-changed" style="display: block; white-space: pre"> end</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
<span class="diff-not-changed" style="display: block; white-space: pre"> def format_attributes</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- attributes_formatter = nil</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> if @request.complex_output?</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- attributes_formatter = ComplexAttributesFormatter.new</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+ formatter = ComplexAttributesFormatter.new</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> else</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- attributes_formatter = SimpleAttributesFormatter.new</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+ formatter = SimpleAttributesFormatter.new</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> end</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- attributes_formatter.format_attributes(</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- output_target_attributes,</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- @result.records</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- )</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+ formatter.format_attributes(output_target_attributes, @result.records)</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> end</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
<span class="diff-not-changed" style="display: block; white-space: pre"> def output_target_attributes</span>
<span class="diff-hunk-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">@@ -640,13 +636,12 @@ <span class="diff-context" style="background-color: #ffffaa; color: #000000">module Droonga</span></span>
<span class="diff-not-changed" style="display: block; white-space: pre"> end</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
<span class="diff-not-changed" style="display: block; white-space: pre"> def format_records</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- records_formatter = nil</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> if @request.complex_output?</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- records_formatter = ComplexRecordsFormatter.new</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+ formatter = ComplexRecordsFormatter.new</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> else</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- records_formatter = SimpleRecordsFormatter.new</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+ formatter = SimpleRecordsFormatter.new</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> end</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- records_formatter.format_records(output_target_attributes, @result.records, output_limit, output_offset)</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+ formatter.format_records(output_target_attributes, @result.records, output_limit, output_offset)</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> end</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
<span class="diff-not-changed" style="display: block; white-space: pre"> def normalize_target_attributes(attributes, domain = @result.records)</span>
</pre>
</td>
</tr>
</tbody>
</table>
</div>
</body>
</html>