<!DOCTYPE html>
<html>
  <head>
  </head>
  <body>
    <dl style="line-height: 1.5; margin-left: 2em">
      <dt style="clear: both; float: left; font-weight: bold; width: 8em">Author</dt>
      <dd style="margin-left: 8.5em">Kouhei Sutou &lt;kou****@clear*****&gt;</dd>
      <dt style="clear: both; float: left; font-weight: bold; width: 8em">Date</dt>
      <dd style="margin-left: 8.5em">2014-06-14 23:24:40 +0900 (Sat, 14 Jun 2014)</dd>
      <dt style="clear: both; float: left; font-weight: bold; width: 8em">New Revision</dt>
      <dd style="margin-left: 8.5em"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374">4c9a9c67f150c1ebc7586d48d4246290c4081374</a></dd>
      <dt style="clear: both; float: left; font-weight: bold; width: 8em">Message</dt>
      <dd style="margin-left: 8.5em"><pre style="border: 1px solid #aaa; font-family: Consolas, Menlo, &quot;Liberation Mono&quot;, Courier, monospace; line-height: 1.2; padding: 0.5em; width: auto">Ensure disposing database object

Reported by Tomoatsu Shimada. Thanks!!!</pre></dd>
      <dt style="clear: both; float: left; font-weight: bold; width: 8em">Modified files</dt>
      <dd style="margin-left: 8.5em">
        <ul>
          <li><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#diff-0">groonga-gobject/ggrn-context.c</a></li>
        </ul>
      </dd>
    </dl>

    <div class="diff-section" style="clear: both">
      <table style="border-collapse: collapse; border: 1px solid #aaa">
        <thead>
          <tr class="diff-header" style="border: 1px solid #aaa">
            <td colspan="3">
<pre style="border: 0; font-family: Consolas, Menlo, &quot;Liberation Mono&quot;, Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">  Modified: groonga-gobject/ggrn-context.c (+12 -2)</span>
<span class="diff-header-mark" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">===================================================================</span>
</pre>
            </td>
          </tr>
        </thead>
        <tbody>
          <tr>
            <th class="diff-line-number" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, &quot;Liberation Mono&quot;, Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0L151">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0L152">152</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0L153">153</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0L154">154</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0L155">155</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0L156">156</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0L157">157</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0L158">158</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0L159">159</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0L160">160</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0L161">161</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0L162">162</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0L176">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0L177">177</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0L178">178</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0L179">179</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0L180">180</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0L181">181</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0L182">182</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0L183">183</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0L184">184</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0L185">185</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0L186">186</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0L187">187</a></span>
</pre>
            </th>
            <th class="diff-line-number" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, &quot;Liberation Mono&quot;, Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R151">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R152">152</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R153">153</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R154">154</a></span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R155">155</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R156">156</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R157">157</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R158">158</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R159">159</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R160">160</a></span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R161">161</a></span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R162">162</a></span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R163">163</a></span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R164">164</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R165">165</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R166">166</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R167">167</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R181">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R182">182</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R183">183</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R184">184</a></span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R185">185</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R186">186</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R187">187</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R188">188</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R189">189</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R190">190</a></span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R191">191</a></span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R192">192</a></span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R193">193</a></span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R194">194</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R195">195</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R196">196</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga-gobject/commit/4c9a9c67f150c1ebc7586d48d4246290c4081374#L0R197">197</a></span>
</pre>
            </th>
            <td class="diff-content" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, &quot;Liberation Mono&quot;, Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-hunk-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">@@ -152,11 +152,16 @@ <span class="diff-context" style="background-color: #ffffaa; color: #000000">ggrn_context_open_database(GGrnContext *context,</span></span>
<span class="diff-not-changed" style="display: block; white-space: pre">                            const gchar *path, GError **error)</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> {</span>
<span class="diff-not-changed" style="display: block; white-space: pre">     GGrnContextPrivate *priv = GGRN_CONTEXT_GET_PRIVATE(context);</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+    gboolean success;</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
<span class="diff-not-changed" style="display: block; white-space: pre">     dispose_database(priv);</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
<span class="diff-not-changed" style="display: block; white-space: pre">     grn_db_open(priv-&gt;ctx, path);</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">-    return _ggrn_context_check(context, error);</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+    success = _ggrn_context_check(context, error);</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+    if (success) {</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+        priv-&gt;own_database = TRUE;</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+    }</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+    return success;</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> }</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
<span class="diff-not-changed" style="display: block; white-space: pre"> /**</span>
<span class="diff-hunk-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">@@ -177,11 +182,16 @@ <span class="diff-context" style="background-color: #ffffaa; color: #000000">ggrn_context_create_database(GGrnContext *context,</span></span>
<span class="diff-not-changed" style="display: block; white-space: pre">                              const gchar *path, GError **error)</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> {</span>
<span class="diff-not-changed" style="display: block; white-space: pre">     GGrnContextPrivate *priv = GGRN_CONTEXT_GET_PRIVATE(context);</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+    gboolean success;</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
<span class="diff-not-changed" style="display: block; white-space: pre">     dispose_database(priv);</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
<span class="diff-not-changed" style="display: block; white-space: pre">     grn_db_create(priv-&gt;ctx, path, NULL);</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">-    return _ggrn_context_check(context, error);</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+    success = _ggrn_context_check(context, error);</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+    if (success) {</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+        priv-&gt;own_database = TRUE;</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+    }</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+    return success;</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> }</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
<span class="diff-not-changed" style="display: block; white-space: pre"> /**</span>
</pre>
            </td>
          </tr>
        </tbody>
      </table>
    </div>
  </body>
</html>