<!DOCTYPE html>
<html>
<head>
</head>
<body>
<dl style="line-height: 1.5; margin-left: 2em">
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Author</dt>
<dd style="margin-left: 8.5em">Kouhei Sutou <kou****@clear*****></dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Date</dt>
<dd style="margin-left: 8.5em">2015-04-17 18:09:59 +0900 (Fri, 17 Apr 2015)</dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">New Revision</dt>
<dd style="margin-left: 8.5em"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f">748edd026f0dc4d279dd183980fbb5f6526bc39f</a></dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Message</dt>
<dd style="margin-left: 8.5em"><pre style="border: 1px solid #aaa; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; padding: 0.5em; width: auto">Improve variable name
It's a size to use as threshold.</pre></dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Modified files</dt>
<dd style="margin-left: 8.5em">
<ul>
<li><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#diff-0">lib/logger.c</a></li>
</ul>
</dd>
</dl>
<div class="diff-section" style="clear: both">
<table style="border-collapse: collapse; border: 1px solid #aaa">
<thead>
<tr class="diff-header" style="border: 1px solid #aaa">
<td colspan="3">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre"> Modified: lib/logger.c (+4 -4)</span>
<span class="diff-header-mark" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">===================================================================</span>
</pre>
</td>
</tr>
</thead>
<tbody>
<tr>
<th class="diff-line-number" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L54">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L55">55</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L56">56</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L57">57</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L58">58</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L59">59</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L60">60</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L61">61</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L89">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L90">90</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L91">91</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L92">92</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L93">93</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L94">94</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L95">95</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L96">96</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L323">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L324">324</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L325">325</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L326">326</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L327">327</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L328">328</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L329">329</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L330">330</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L349">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L350">350</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L351">351</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L352">352</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L353">353</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L354">354</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L355">355</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0L356">356</a></span>
</pre>
</th>
<th class="diff-line-number" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R54">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R55">55</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R56">56</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R57">57</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R58">58</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R59">59</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R60">60</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R61">61</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R89">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R90">90</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R91">91</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R92">92</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R93">93</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R94">94</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R95">95</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R96">96</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R323">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R324">324</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R325">325</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R326">326</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R327">327</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R328">328</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R329">329</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R330">330</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R349">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R350">350</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R351">351</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R352">352</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R353">353</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R354">354</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R355">355</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/748edd026f0dc4d279dd183980fbb5f6526bc39f#L0R356">356</a></span>
</pre>
</th>
<td class="diff-content" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-hunk-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">@@ -55,7 +55,7 @@ <span class="diff-context" style="background-color: #ffffaa; color: #000000">static char *default_logger_path = NULL;</span></span>
<span class="diff-not-changed" style="display: block; white-space: pre"> static FILE *default_logger_file = NULL;</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> static grn_critical_section default_logger_lock;</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> static off_t default_logger_size = 0;</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">-static off_t default_logger_rotate_size_threshold = 0;</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+static off_t default_logger_rotate_threshold_size = 0;</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
<span class="diff-not-changed" style="display: block; white-space: pre"> #define LOGGER_NEED_ROTATE(size, threshold) \</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> ((threshold) > 0 && (size) >= (threshold))</span>
<span class="diff-hunk-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">@@ -90,7 +90,7 @@ <span class="diff-context" style="background-color: #ffffaa; color: #000000">default_logger_log(grn_ctx *ctx, grn_log_level level,</span></span>
<span class="diff-not-changed" style="display: block; white-space: pre"> if (written > 0) {</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> default_logger_size += written;</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> if (LOGGER_NEED_ROTATE(default_logger_size,</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- default_logger_rotate_size_threshold)) {</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+ default_logger_rotate_threshold_size)) {</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> fclose(default_logger_file);</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> default_logger_file = NULL;</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> rotate_log_file(ctx, default_logger_path);</span>
<span class="diff-hunk-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">@@ -324,7 +324,7 @@ <span class="diff-context" style="background-color: #ffffaa; color: #000000">static char *default_query_logger_path = NULL;</span></span>
<span class="diff-not-changed" style="display: block; white-space: pre"> static FILE *default_query_logger_file = NULL;</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> static grn_critical_section default_query_logger_lock;</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> static off_t default_query_logger_size = 0;</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">-static off_t default_query_logger_rotate_size_threshold = 0;</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+static off_t default_query_logger_rotate_threshold_size = 0;</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
<span class="diff-not-changed" style="display: block; white-space: pre"> static void</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> default_query_logger_log(grn_ctx *ctx, unsigned int flag,</span>
<span class="diff-hunk-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">@@ -350,7 +350,7 @@ <span class="diff-context" style="background-color: #ffffaa; color: #000000">default_query_logger_log(grn_ctx *ctx, unsigned int flag,</span></span>
<span class="diff-not-changed" style="display: block; white-space: pre"> if (written > 0) {</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> default_query_logger_size += written;</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> if (LOGGER_NEED_ROTATE(default_query_logger_size,</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- default_query_logger_rotate_size_threshold)) {</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+ default_query_logger_rotate_threshold_size)) {</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> fclose(default_query_logger_file);</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> default_query_logger_file = NULL;</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> rotate_log_file(ctx, default_query_logger_path);</span>
</pre>
</td>
</tr>
</tbody>
</table>
</div>
</body>
</html>