<!DOCTYPE html>
<html>
<head>
</head>
<body>
<dl style="line-height: 1.5; margin-left: 2em">
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Author</dt>
<dd style="margin-left: 8.5em">Kouhei Sutou <kou****@clear*****></dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Date</dt>
<dd style="margin-left: 8.5em">2017-04-10 16:17:03 +0900 (Mon, 10 Apr 2017)</dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">New Revision</dt>
<dd style="margin-left: 8.5em"><a href="https://github.com/groonga/groonga/commit/a071b5cc6a16855a266a92df567898affdd48681">a071b5cc6a16855a266a92df567898affdd48681</a></dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Message</dt>
<dd style="margin-left: 8.5em"><pre style="border: 1px solid #aaa; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; padding: 0.5em; width: auto">logical_select: reduce needless expression creation</pre></dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Modified files</dt>
<dd style="margin-left: 8.5em">
<ul>
<li><a href="https://github.com/groonga/groonga/commit/a071b5cc6a16855a266a92df567898affdd48681#diff-8b4222f5078cb869e8e561c84c589020">plugins/sharding/logical_select.rb</a></li>
</ul>
</dd>
</dl>
<div class="diff-section" style="clear: both">
<table style="border-collapse: collapse; border: 1px solid #aaa">
<thead>
<tr class="diff-header" style="border: 1px solid #aaa">
<td colspan="3">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre"> Modified: plugins/sharding/logical_select.rb (+2 -0)</span>
<span class="diff-header-mark" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">===================================================================</span>
</pre>
</td>
</tr>
</thead>
<tbody>
<tr>
<th class="diff-line-number" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/a071b5cc6a16855a266a92df567898affdd48681#diff-8b4222f5078cb869e8e561c84c589020L439">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/a071b5cc6a16855a266a92df567898affdd48681#diff-8b4222f5078cb869e8e561c84c589020L440">440</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/a071b5cc6a16855a266a92df567898affdd48681#diff-8b4222f5078cb869e8e561c84c589020L441">441</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/a071b5cc6a16855a266a92df567898affdd48681#diff-8b4222f5078cb869e8e561c84c589020L442">442</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/a071b5cc6a16855a266a92df567898affdd48681#diff-8b4222f5078cb869e8e561c84c589020L443">443</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/a071b5cc6a16855a266a92df567898affdd48681#diff-8b4222f5078cb869e8e561c84c589020L444">444</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/a071b5cc6a16855a266a92df567898affdd48681#diff-8b4222f5078cb869e8e561c84c589020L445">445</a></span>
</pre>
</th>
<th class="diff-line-number" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/a071b5cc6a16855a266a92df567898affdd48681#diff-8b4222f5078cb869e8e561c84c589020R439">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/a071b5cc6a16855a266a92df567898affdd48681#diff-8b4222f5078cb869e8e561c84c589020R440">440</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/a071b5cc6a16855a266a92df567898affdd48681#diff-8b4222f5078cb869e8e561c84c589020R441">441</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/a071b5cc6a16855a266a92df567898affdd48681#diff-8b4222f5078cb869e8e561c84c589020R442">442</a></span>
<span class="diff-line-number-added" style="background-color: #eaffea; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/a071b5cc6a16855a266a92df567898affdd48681#diff-8b4222f5078cb869e8e561c84c589020R443">443</a></span>
<span class="diff-line-number-added" style="background-color: #eaffea; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/a071b5cc6a16855a266a92df567898affdd48681#diff-8b4222f5078cb869e8e561c84c589020R444">444</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/a071b5cc6a16855a266a92df567898affdd48681#diff-8b4222f5078cb869e8e561c84c589020R445">445</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/a071b5cc6a16855a266a92df567898affdd48681#diff-8b4222f5078cb869e8e561c84c589020R446">446</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/a071b5cc6a16855a266a92df567898affdd48681#diff-8b4222f5078cb869e8e561c84c589020R447">447</a></span>
</pre>
</th>
<td class="diff-content" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-hunk-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">@@ -440,6 +440,8 @@ <span class="diff-context" style="background-color: #ffffaa; color: #000000">module Groonga</span></span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
<span class="diff-not-changed" style="display: block; white-space: pre"> def apply(table, condition=nil)</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> column = table.create_column(@label, @flags, @type)</span>
<span class="diff-added" style="background-color: #eaffea; color: #000000; display: block; white-space: pre">+ return if table.empty?</span>
<span class="diff-added" style="background-color: #eaffea; color: #000000; display: block; white-space: pre">+</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> expression = Expression.create(table)</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> begin</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> expression.parse(@value)</span>
</pre>
</td>
</tr>
</tbody>
</table>
</div>
</body>
</html>