<!DOCTYPE html>
<html>
  <head>
  </head>
  <body>
    <dl style="line-height: 1.5; margin-left: 2em">
      <dt style="clear: both; float: left; font-weight: bold; width: 8em">Author</dt>
      <dd style="margin-left: 8.5em">Kouhei Sutou &lt;kou****@clear*****&gt;</dd>
      <dt style="clear: both; float: left; font-weight: bold; width: 8em">Date</dt>
      <dd style="margin-left: 8.5em">2018-06-22 16:37:19 +0900 (Fri, 22 Jun 2018)</dd>
      <dt style="clear: both; float: left; font-weight: bold; width: 8em">New Revision</dt>
      <dd style="margin-left: 8.5em"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341">d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341</a></dd>
      <dt style="clear: both; float: left; font-weight: bold; width: 8em">Message</dt>
      <dd style="margin-left: 8.5em"><pre style="border: 1px solid #aaa; font-family: Consolas, Menlo, &quot;Liberation Mono&quot;, Courier, monospace; line-height: 1.2; padding: 0.5em; width: auto">window_sum: support dynamic column as a target column</pre></dd>
      <dt style="clear: both; float: left; font-weight: bold; width: 8em">Modified files</dt>
      <dd style="margin-left: 8.5em">
        <ul>
          <li><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397ef">lib/window_functions.c</a></li>
        </ul>
      </dd>
    </dl>

    <div class="diff-section" style="clear: both">
      <table style="border-collapse: collapse; border: 1px solid #aaa">
        <thead>
          <tr class="diff-header" style="border: 1px solid #aaa">
            <td colspan="3">
<pre style="border: 0; font-family: Consolas, Menlo, &quot;Liberation Mono&quot;, Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">  Modified: lib/window_functions.c (+5 -3)</span>
<span class="diff-header-mark" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">===================================================================</span>
</pre>
            </td>
          </tr>
        </thead>
        <tbody>
          <tr>
            <th class="diff-line-number" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, &quot;Liberation Mono&quot;, Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397ef">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efL1">1</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efL2">2</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffecec; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efL3">3</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efL4">4</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efL5">5</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efL6">6</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efL59">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efL60">60</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efL61">61</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efL62">62</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffecec; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efL63">63</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efL64">64</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efL65">65</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efL66">66</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efL67">67</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efL68">68</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efL69">69</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffecec; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efL70">70</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efL71">71</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efL72">72</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efL73">73</a></span>
</pre>
            </th>
            <th class="diff-line-number" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, &quot;Liberation Mono&quot;, Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397ef">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efR1">1</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efR2">2</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-added" style="background-color: #eaffea; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efR3">3</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efR4">4</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efR5">5</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efR6">6</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efR59">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efR60">60</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efR61">61</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efR62">62</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-added" style="background-color: #eaffea; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efR63">63</a></span>
<span class="diff-line-number-added" style="background-color: #eaffea; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efR64">64</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efR65">65</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efR66">66</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efR67">67</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efR68">68</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efR69">69</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efR70">70</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-added" style="background-color: #eaffea; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efR71">71</a></span>
<span class="diff-line-number-added" style="background-color: #eaffea; color: #000000; display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efR72">72</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efR73">73</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efR74">74</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/groonga/groonga/commit/d6c8f4c56dfad0e1c1b0b050bcdf6fc901796341#diff-a37fcd372732f1f47f2e7c17191397efR75">75</a></span>
</pre>
            </th>
            <td class="diff-content" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, &quot;Liberation Mono&quot;, Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-hunk-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">@@ -1,6 +1,6 @@</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> /* -*- c-basic-offset: 2 -*- */</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> /*</span>
<span class="diff-deleted" style="background-color: #ffecec; color: #000000; display: block; white-space: pre">-  Copyright(C) 2016-201<span class="diff-deleted-word" style="background-color: #f8cbcb; color: #000000">7</span> Brazil</span>
<span class="diff-added" style="background-color: #eaffea; color: #000000; display: block; white-space: pre">+  Copyright(C) 2016-201<span class="diff-added-word" style="background-color: #a6f3a6; color: #000000">8</span> Brazil</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
<span class="diff-not-changed" style="display: block; white-space: pre">   This library is free software; you can redistribute it and/or</span>
<span class="diff-not-changed" style="display: block; white-space: pre">   modify it under the terms of the GNU Lesser General Public</span>
<span class="diff-hunk-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">@@ -60,14 +60,16 @@ <span class="diff-context" style="background-color: #ffffaa; color: #000000">window_sum(grn_ctx *ctx,</span></span>
<span class="diff-not-changed" style="display: block; white-space: pre">   }</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
<span class="diff-not-changed" style="display: block; white-space: pre">   target = args[0];</span>
<span class="diff-deleted" style="background-color: #ffecec; color: #000000; display: block; white-space: pre">-  if (target-&gt;header.type != GRN_ACCESSOR) {</span>
<span class="diff-added" style="background-color: #eaffea; color: #000000; display: block; white-space: pre">+  if (!(grn_obj_is_scalar_column(ctx, target) ||</span>
<span class="diff-added" style="background-color: #eaffea; color: #000000; display: block; white-space: pre">+        grn_obj_is_accessor(ctx, target))) {</span>
<span class="diff-not-changed" style="display: block; white-space: pre">     grn_obj inspected;</span>
<span class="diff-not-changed" style="display: block; white-space: pre">     GRN_TEXT_INIT(&amp;inspected, 0);</span>
<span class="diff-not-changed" style="display: block; white-space: pre">     grn_inspect(ctx, &amp;inspected, target);</span>
<span class="diff-not-changed" style="display: block; white-space: pre">     GRN_PLUGIN_ERROR(ctx,</span>
<span class="diff-not-changed" style="display: block; white-space: pre">                      GRN_INVALID_ARGUMENT,</span>
<span class="diff-not-changed" style="display: block; white-space: pre">                      &quot;window_sum(): &quot;</span>
<span class="diff-deleted" style="background-color: #ffecec; color: #000000; display: block; white-space: pre">-                     &quot;the target column must be accessor: &lt;%.*s&gt;&quot;,</span>
<span class="diff-added" style="background-color: #eaffea; color: #000000; display: block; white-space: pre">+                     &quot;the target column must be &quot;</span>
<span class="diff-added" style="background-color: #eaffea; color: #000000; display: block; white-space: pre">+                     &quot;scalar column or accessor: &lt;%.*s&gt;&quot;,</span>
<span class="diff-not-changed" style="display: block; white-space: pre">                      (int)GRN_TEXT_LEN(&amp;inspected),</span>
<span class="diff-not-changed" style="display: block; white-space: pre">                      GRN_TEXT_VALUE(&amp;inspected));</span>
<span class="diff-not-changed" style="display: block; white-space: pre">     GRN_OBJ_FIN(ctx, &amp;inspected);</span>
</pre>
            </td>
          </tr>
        </tbody>
      </table>
    </div>
  </body>
</html>