<!DOCTYPE html>
<html>
<head>
</head>
<body>
<dl style="line-height: 1.5; margin-left: 2em">
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Author</dt>
<dd style="margin-left: 8.5em">Kouhei Sutou <kou****@clear*****></dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Date</dt>
<dd style="margin-left: 8.5em">2012-03-08 21:35:20 +0900 (Thu, 08 Mar 2012)</dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">New Revision</dt>
<dd style="margin-left: 8.5em"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d">c0687a89880b116d944ab3ce3972b8cdfa3e284d</a></dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Log</dt>
<dd style="margin-left: 8.5em"><pre style="border: 1px solid #aaa; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; padding: 0.5em">Add empty string check</pre></dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Modified files</dt>
<dd style="margin-left: 8.5em">
<ul>
<li><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#diff-0">mrn_table.cc</a></li>
</ul>
</dd>
</dl>
<div class="diff-section" style="clear: both">
<table style="border-collapse: collapse; border: 1px solid #aaa">
<thead>
<tr class="diff-header" style="border: 1px solid #aaa">
<td colspan="3">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal"><span class="diff-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre"> Modified: mrn_table.cc (+5 -2)</span>
<span class="diff-header-mark" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">===================================================================</span>
</pre>
</td>
</tr>
</thead>
<tbody>
<tr>
<th class="diff-line-number" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal"><span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0L34">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0L35">35</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0L36">36</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0L37">37</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0L38">38</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0L39">39</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0L40">40</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0L341">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0L342">342</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0L343">343</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0L344">344</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0L345">345</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0L346">346</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0L347">347</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0L348">348</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0L355">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0L356">356</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0L357">357</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0L358">358</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0L359">359</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0L360">360</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0L361">361</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0L362">362</a></span>
</pre>
</th>
<th class="diff-line-number" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal"><span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R34">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R35">35</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R36">36</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R37">37</a></span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R38">38</a></span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R39">39</a></span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R40">40</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R41">41</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R42">42</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R43">43</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R344">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R345">345</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R346">346</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R347">347</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R348">348</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R349">349</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R350">350</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R351">351</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R358">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R359">359</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R360">360</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R361">361</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R362">362</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R363">363</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R364">364</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/c0687a89880b116d944ab3ce3972b8cdfa3e284d#L0R365">365</a></span>
</pre>
</th>
<td class="diff-content" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal"><span class="diff-hunk-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">@@ -35,6 +35,9 @@</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> # define MRN_HA_RESOLVE_BY_NAME(name) ha_resolve_by_name(NULL, (name))</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> #endif</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+#define LEX_STRING_IS_EMPTY(string) \</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+ ((string).length == 0 || !(string).str || (string).str[0] == '\0')</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> #define MRN_DEFAULT_STR "DEFAULT"</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> #define MRN_DEFAULT_LEN (sizeof(MRN_DEFAULT_STR) - 1)</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> #define MRN_GROONGA_STR "GROONGA"</span>
<span class="diff-hunk-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">@@ -342,7 +345,7 @@ <span class="diff-context" style="background-color: #ffffaa; color: #000000">int mrn_parse_table_param(MRN_SHARE *share, TABLE *table)</span></span>
<span class="diff-not-changed" style="display: block; white-space: pre"> break;</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> #endif</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> case 2:</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- if (table->s->comment.length == 0)</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+ if (LEX_STRING_IS_EMPTY(table->s->comment))</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> continue;</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> DBUG_PRINT("info", ("mroonga create comment string"));</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> if (</span>
<span class="diff-hunk-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">@@ -356,7 +359,7 @@ <span class="diff-context" style="background-color: #ffffaa; color: #000000">int mrn_parse_table_param(MRN_SHARE *share, TABLE *table)</span></span>
<span class="diff-not-changed" style="display: block; white-space: pre"> DBUG_PRINT("info", ("mroonga comment string=%s", param_string));</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> break;</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> default:</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">- if (table->s->connect_string.length == 0)</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+ if (LEX_STRING_IS_EMPTY(table->s->connect_string))</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> continue;</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> DBUG_PRINT("info", ("mroonga create connect_string string"));</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> if (</span>
</pre>
</td>
</tr>
</tbody>
</table>
</div>
</body>
</html>