<!DOCTYPE html>
<html>
  <head>
  </head>
  <body>
    <dl style="line-height: 1.5; margin-left: 2em">
      <dt style="clear: both; float: left; font-weight: bold; width: 8em">Author</dt>
      <dd style="margin-left: 8.5em">Kouhei Sutou &lt;kou****@clear*****&gt;</dd>
      <dt style="clear: both; float: left; font-weight: bold; width: 8em">Date</dt>
      <dd style="margin-left: 8.5em">2011-12-18 12:37:22 +0900 (Sun, 18 Dec 2011)</dd>
      <dt style="clear: both; float: left; font-weight: bold; width: 8em">New Revision</dt>
      <dd style="margin-left: 8.5em"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f">3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f</a></dd>
      <dt style="clear: both; float: left; font-weight: bold; width: 8em">Log</dt>
      <dd style="margin-left: 8.5em"><pre style="border: 1px solid #aaa; font-family: Consolas, Menlo, &quot;Liberation Mono&quot;, Courier, monospace; line-height: 1.2; padding: 0.5em">use meaningful variable names. refs #1196</pre></dd>
      <dt style="clear: both; float: left; font-weight: bold; width: 8em">Modified files</dt>
      <dd style="margin-left: 8.5em">
        <ul>
          <li><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#diff-0">ha_mroonga.cc</a></li>
        </ul>
      </dd>
    </dl>

    <div class="diff-section" style="clear: both">
      <table style="border-collapse: collapse; border: 1px solid #aaa">
        <thead>
          <tr class="diff-header" style="border: 1px solid #aaa">
            <td colspan="3">
<pre style="border: 0; font-family: Consolas, Menlo, &quot;Liberation Mono&quot;, Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal"><span class="diff-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">  Modified: ha_mroonga.cc (+7 -7)</span>
<span class="diff-header-mark" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">===================================================================</span>
</pre>
            </td>
          </tr>
        </thead>
        <tbody>
          <tr>
            <th class="diff-line-number" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, &quot;Liberation Mono&quot;, Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal"><span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8649">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8650">8650</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8651">8651</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8652">8652</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8653">8653</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8654">8654</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8655">8655</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8656">8656</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8657">8657</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8658">8658</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8659">8659</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8660">8660</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8661">8661</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8662">8662</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8663">8663</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8669">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8670">8670</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8671">8671</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8672">8672</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8673">8673</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8674">8674</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8675">8675</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8676">8676</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8677">8677</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8678">8678</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8679">8679</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8680">8680</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8681">8681</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8682">8682</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0L8683">8683</a></span>
</pre>
            </th>
            <th class="diff-line-number" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, &quot;Liberation Mono&quot;, Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal"><span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8649">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8650">8650</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8651">8651</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8652">8652</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8653">8653</a></span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8654">8654</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8655">8655</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8656">8656</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8657">8657</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8658">8658</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8659">8659</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8660">8660</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8661">8661</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8662">8662</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8663">8663</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8669">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8670">8670</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8671">8671</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8672">8672</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8673">8673</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8674">8674</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8675">8675</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8676">8676</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8677">8677</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8678">8678</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8679">8679</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre">&nbsp;</span>
<span class="diff-line-number-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8680">8680</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8681">8681</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8682">8682</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/3fcdb9de4937ea4a2bf0ffd611cec9f4810e324f#L0R8683">8683</a></span>
</pre>
            </th>
            <td class="diff-content" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, &quot;Liberation Mono&quot;, Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal"><span class="diff-hunk-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">@@ -8650,14 +8650,14 @@ <span class="diff-context" style="background-color: #ffffaa; color: #000000">void ha_mroonga::change_table_ptr(TABLE *table_arg, TABLE_SHARE *share_arg)</span></span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
<span class="diff-not-changed" style="display: block; white-space: pre"> bool ha_mroonga::wrapper_primary_key_is_clustered()</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> {</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">-  bool res;</span>
<span class="diff-not-changed" style="display: block; white-space: pre">   MRN_DBUG_ENTER_METHOD();</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+  bool is_clustered;</span>
<span class="diff-not-changed" style="display: block; white-space: pre">   MRN_SET_WRAP_SHARE_KEY(share, table-&gt;s);</span>
<span class="diff-not-changed" style="display: block; white-space: pre">   MRN_SET_WRAP_TABLE_KEY(this, table);</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">-  res = wrap_handler-&gt;primary_key_is_clustered();</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+  is_clustered = wrap_handler-&gt;primary_key_is_clustered();</span>
<span class="diff-not-changed" style="display: block; white-space: pre">   MRN_SET_BASE_SHARE_KEY(share, table-&gt;s);</span>
<span class="diff-not-changed" style="display: block; white-space: pre">   MRN_SET_BASE_TABLE_KEY(this, table);</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">-  DBUG_RETURN(res);</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+  DBUG_RETURN(is_clustered);</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> }</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
<span class="diff-not-changed" style="display: block; white-space: pre"> bool ha_mroonga::storage_primary_key_is_clustered()</span>
<span class="diff-hunk-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">@@ -8670,14 +8670,14 @@ <span class="diff-context" style="background-color: #ffffaa; color: #000000">bool ha_mroonga::storage_primary_key_is_clustered()</span></span>
<span class="diff-not-changed" style="display: block; white-space: pre"> bool ha_mroonga::primary_key_is_clustered()</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> {</span>
<span class="diff-not-changed" style="display: block; white-space: pre">   MRN_DBUG_ENTER_METHOD();</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">-  bool res;</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+  bool is_clustered;</span>
<span class="diff-not-changed" style="display: block; white-space: pre">   if (share-&gt;wrapper_mode)</span>
<span class="diff-not-changed" style="display: block; white-space: pre">   {</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">-    res = wrapper_primary_key_is_clustered();</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+    is_clustered = wrapper_primary_key_is_clustered();</span>
<span class="diff-not-changed" style="display: block; white-space: pre">   } else {</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">-    res = storage_primary_key_is_clustered();</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+    is_clustered = storage_primary_key_is_clustered();</span>
<span class="diff-not-changed" style="display: block; white-space: pre">   }</span>
<span class="diff-deleted" style="background-color: #ffaaaa; color: #000000; display: block; white-space: pre">-  DBUG_RETURN(res);</span>
<span class="diff-added" style="background-color: #aaffaa; color: #000000; display: block; white-space: pre">+  DBUG_RETURN(is_clustered);</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> }</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
<span class="diff-not-changed" style="display: block; white-space: pre"> #ifdef __cplusplus</span>
</pre>
            </td>
          </tr>
        </tbody>
      </table>
    </div>
  </body>
</html>