<!DOCTYPE html>
<html>
<head>
</head>
<body>
<dl style="line-height: 1.5; margin-left: 2em">
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Author</dt>
<dd style="margin-left: 8.5em">Kouhei Sutou <kou****@clear*****></dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Date</dt>
<dd style="margin-left: 8.5em">2018-01-29 18:06:27 +0900 (Mon, 29 Jan 2018)</dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">New Revision</dt>
<dd style="margin-left: 8.5em"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0">ca20ae45feceea0acdb7f12657d9a6226919b8a0</a></dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Message</dt>
<dd style="margin-left: 8.5em"><pre style="border: 1px solid #aaa; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; padding: 0.5em; width: auto">Fix a memory leak
Column caches aren't freed.</pre></dd>
<dt style="clear: both; float: left; font-weight: bold; width: 8em">Modified files</dt>
<dd style="margin-left: 8.5em">
<ul>
<li><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2">ha_mroonga.cpp</a></li>
</ul>
</dd>
</dl>
<div class="diff-section" style="clear: both">
<table style="border-collapse: collapse; border: 1px solid #aaa">
<thead>
<tr class="diff-header" style="border: 1px solid #aaa">
<td colspan="3">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre"> Modified: ha_mroonga.cpp (+3 -4)</span>
<span class="diff-header-mark" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">===================================================================</span>
</pre>
</td>
</tr>
</thead>
<tbody>
<tr>
<th class="diff-line-number" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2L5075">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2L5076">5076</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2L5077">5077</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2L5078">5078</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2L5079">5079</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2L5080">5080</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2L5081">5081</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2L5265">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2L5266">5266</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2L5267">5267</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2L5268">5268</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2L5269">5269</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffecec; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2L5270">5270</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffecec; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2L5271">5271</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffecec; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2L5272">5272</a></span>
<span class="diff-line-number-deleted" style="background-color: #ffecec; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2L5273">5273</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2L5274">5274</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2L5275">5275</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2L5276">5276</a></span>
</pre>
</th>
<th class="diff-line-number" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2R5075">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2R5076">5076</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2R5077">5077</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2R5078">5078</a></span>
<span class="diff-line-number-added" style="background-color: #eaffea; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2R5079">5079</a></span>
<span class="diff-line-number-added" style="background-color: #eaffea; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2R5080">5080</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2R5081">5081</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2R5082">5082</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2R5083">5083</a></span>
<span class="diff-line-number-hunk-header" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2R5267">...</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2R5268">5268</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2R5269">5269</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2R5270">5270</a></span>
<span class="diff-line-number-added" style="background-color: #eaffea; color: #000000; display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2R5271">5271</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2R5272">5272</a></span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-nothing" style="display: block; white-space: pre"> </span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2R5273">5273</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2R5274">5274</a></span>
<span class="diff-line-number-not-changed" style="display: block; white-space: pre"><a href="https://github.com/mroonga/mroonga/commit/ca20ae45feceea0acdb7f12657d9a6226919b8a0#diff-ba714ec217aa6836e39b3aea9da57ae2R5275">5275</a></span>
</pre>
</th>
<td class="diff-content" style="border: 1px solid #aaa">
<pre style="border: 0; font-family: Consolas, Menlo, "Liberation Mono", Courier, monospace; line-height: 1.2; margin: 0; padding: 0.5em; white-space: normal; width: auto"><span class="diff-hunk-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">@@ -5076,6 +5076,8 @@ <span class="diff-context" style="background-color: #ffffaa; color: #000000">void ha_mroonga::storage_close_columns(void)</span></span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
<span class="diff-not-changed" style="display: block; white-space: pre"> free(grn_columns);</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> grn_columns = NULL;</span>
<span class="diff-added" style="background-color: #eaffea; color: #000000; display: block; white-space: pre">+ free(grn_column_caches);</span>
<span class="diff-added" style="background-color: #eaffea; color: #000000; display: block; white-space: pre">+ grn_column_caches = NULL;</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> free(grn_column_ranges);</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> grn_column_ranges = NULL;</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> }</span>
<span class="diff-hunk-header" style="background-color: #eaf2f5; color: #999999; display: block; white-space: pre">@@ -5266,11 +5268,8 @@ <span class="diff-context" style="background-color: #ffffaa; color: #000000">int ha_mroonga::wrapper_close()</span></span>
<span class="diff-not-changed" style="display: block; white-space: pre"> int ha_mroonga::storage_close()</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> {</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> MRN_DBUG_ENTER_METHOD();</span>
<span class="diff-added" style="background-color: #eaffea; color: #000000; display: block; white-space: pre">+ storage_close_columns();</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> grn_obj_unlink(ctx, grn_table);</span>
<span class="diff-deleted" style="background-color: #ffecec; color: #000000; display: block; white-space: pre">- // TODO: unlink elements</span>
<span class="diff-deleted" style="background-color: #ffecec; color: #000000; display: block; white-space: pre">- free(grn_columns);</span>
<span class="diff-deleted" style="background-color: #ffecec; color: #000000; display: block; white-space: pre">- // TODO: unlink elements</span>
<span class="diff-deleted" style="background-color: #ffecec; color: #000000; display: block; white-space: pre">- free(grn_column_ranges);</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> DBUG_RETURN(0);</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> }</span>
<span class="diff-not-changed" style="display: block; white-space: pre"> </span>
</pre>
</td>
</tr>
</tbody>
</table>
</div>
</body>
</html>